Skip jpeg comparison tests with PIL#5169
Merged
NicolasHug merged 2 commits intopytorch:mainfrom Jan 6, 2022
Merged
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 0b1e742 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 8, 2022
Reviewed By: sallysyw Differential Revision: D33479265 fbshipit-source-id: 2ac5eef5b9224f3c94687cf9921e0cf5bf7cbc9d
datumbox
pushed a commit
to datumbox/vision
that referenced
this pull request
Jan 20, 2022
# Conflicts: # test/test_image.py
datumbox
added a commit
to datumbox/vision
that referenced
this pull request
Jan 20, 2022
# Conflicts: # test/test_image.py
datumbox
added a commit
that referenced
this pull request
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux and MacOS CIs are failing because the latest PIL 9 version now relies on libjpeg-turbo (it used to be the case only for Windows). Torchvision relies on libjpeg, not libjpeg-turbo, hence the comparison test failures.
We skip them in this PR to put CI back to green. This is only temporary until we find a better solution, tracked in #5162.